Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error with latest compilers. (#1) #2

Merged

Conversation

wep21
Copy link

@wep21 wep21 commented May 8, 2024

With the latest compilers (gcc 11 and up), there are errors compiling this package. The compilers warn about variadic macros needing at least one argument.

This fixes that warning by making sure that is always the case using a %s specifier. With this in place, the compiler warnings are gone.

With the latest compilers (gcc 11 and up), there are
errors compiling this package.  The compilers warn
about variadic macros needing at least one argument.

This fixes that warning by making sure that is always
the case using a %s specifier.  With this in place,
the compiler warnings are gone.

Signed-off-by: Chris Lalancette <[email protected]>
@wep21
Copy link
Author

wep21 commented May 8, 2024

closes ros2-gbp/sophus-release#3
@clalancette I appreciate it if you could review this PR.

@wep21
Copy link
Author

wep21 commented May 18, 2024

@clalancette friendly ping

1 similar comment
@wep21
Copy link
Author

wep21 commented May 31, 2024

@clalancette friendly ping

Copy link
Owner

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. This looks good to me, merging.

@clalancette clalancette merged commit 3aaf007 into clalancette:release/1.22.x Jun 5, 2024
5 of 6 checks passed
@wep21 wep21 deleted the fix-macros-compiler-error branch July 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants